London | 26-ITP-May | Remi M. | Sprint 3 | 2-practice-tdd#1326
Open
remimarcelle wants to merge 3 commits into
Open
London | 26-ITP-May | Remi M. | Sprint 3 | 2-practice-tdd#1326remimarcelle wants to merge 3 commits into
remimarcelle wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
remimarcelle
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
remimarcelle
force-pushed
the
coursework/sprint-3-practice-tdd
branch
from
d7628a7 to
5e37cc1
Compare
remimarcelle
added
Needs Review
Author
This was referenced May 25, 2026
This was
linked to
issues
May 25, 2026
cjyuan
reviewed
May 28, 2026
Contributor
There was a problem hiding this comment.
-
Could consider testing a few more samples in this script - higher chance to detect bugs in code.
-
The original specification did not clearly state whether the character match should be case-sensitive.
Most people would probably assume that it is, but to demonstrate our understanding or clarify the assumption we made, we could add test cases to convey this. For examples,- A case to show that the match is case sensitive
- A case to show that the function is expected to work also for non-alphabets
| * | ||
| * @param {string} stringOfCharacters - The string to search through. | ||
| * @param {string} findCharacter - The single character to count. | ||
| * @returns {number} The number of times findCharacter appears in stringOfCharacters. |
Contributor
There was a problem hiding this comment.
Excellent documentation work here!
| // Case 5: All other numbers | ||
| // When the number does not end with 1, 2, or 3 (and is not an exception), | ||
| // Then the function should return a string by appending "th" to the number. | ||
| test("should append 'th' for all other numbers", () => { |
Contributor
There was a problem hiding this comment.
When a test fails with the message "... all other numbers", it may be unclear what "other numbers" actually refers to.
Can you revise the test description to make it more informative?
Contributor
There was a problem hiding this comment.
Have you tried running this script to ensure everything works as expected?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed implement and rewrite jest tests and practicing test driven development exercises and tests.